Add min_size to detect_color_card kwargs
#1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add min_size to kwargs to act in _is_square filtering
add min_size
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 158 158
Lines 6975 6976 +1
=======================================
+ Hits 6974 6975 +1
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Noah is busy this afternoon so @annacasto could you review this PR? |
|
@HaleySchuhl I got this one, I think Anna is going to do the second one! |
k034b363
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add min_size to
detect_color_cardkwargsType of update
Is this a:
Associated issues
Reference associated issue numbers. Does this pull request close any issues?
Additional context
Low resolution images plus small color card varieties can make color cards too small for detection at the default 1000 pixel filtering size. Enable users to lower this if it helps in their dataset.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md