Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error in documentation for camera calibration #1505

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

annacasto
Copy link
Contributor

@annacasto annacasto commented Apr 25, 2024

Describe your changes
Changed listed input parameters and code block from "mtx" and "dist" to "mtx_filename" and "dist_filename."

Type of update
Is this a:

  • Update to documentation

Associated issues
#1504

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@annacasto annacasto linked an issue Apr 25, 2024 that may be closed by this pull request
Copy link

deepsource-io bot commented Apr 25, 2024

Here's the code health analysis summary for commits 47e5835..9951984. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage99.7%99.7%
Line Coverage99.7%99.7%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren nfahlgren added the documentation Documentation issues or features label Apr 25, 2024
@nfahlgren nfahlgren added this to the PlantCV v4.3 milestone Apr 25, 2024
@nfahlgren nfahlgren merged commit 127c358 into main Apr 25, 2024
5 checks passed
@nfahlgren nfahlgren deleted the 1504-docs-correction-for-camera_calibration branch April 25, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issues or features
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Error in the docs for the camera_calibration function
3 participants