Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fewer contours in testing roi_objects #844

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

JorgeGtz
Copy link
Contributor

@JorgeGtz JorgeGtz commented Dec 7, 2021

Describe your changes
The files used in the tests (roi_objects and object_composition) before contained ~1800 contours, which can be computationally heavy.
This PR reduces the numbers of contours used.

Type of update
Is this a:

  • Reduction in test time

Associated issues
NA

Additional context
The tests take a long time to complete.

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #844 (71e918a) into master (b51b545) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #844    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          152       142    -10     
  Lines         6919      6223   -696     
==========================================
- Hits          6919      6223   -696     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/__init__.py 100.00% <0.00%> (ø)
plantcv/plantcv/_debug.py 100.00% <0.00%> (ø)
plantcv/plantcv/classes.py 100.00% <0.00%> (ø)
plantcv/plantcv/plot_image.py 100.00% <0.00%> (ø)
plantcv/plantcv/print_image.py 100.00% <0.00%> (ø)
plantcv/plantcv/photosynthesis/__init__.py 100.00% <0.00%> (ø)
...lantcv/plantcv/photosynthesis/read_cropreporter.py 100.00% <0.00%> (ø)
plantcv/plantcv/homology/constellaqc.py
plantcv/plantcv/homology/starscape.py
plantcv/plantcv/_show_dataarray.py
... and 7 more

@JorgeGtz JorgeGtz added ready to review testing Features related to testing and deployment labels Dec 7, 2021
Copy link
Member

@nfahlgren nfahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nfahlgren nfahlgren merged commit f1c0981 into master Dec 9, 2021
@nfahlgren nfahlgren deleted the reduce-computations-test-roi-objects branch December 9, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review testing Features related to testing and deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants