-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameters to mean adaptive thresh #937
Merged
nfahlgren
merged 49 commits into
release-4.0
from
add-parameters-to-mean-adaptive-thresh
Oct 14, 2022
Merged
Add parameters to mean adaptive thresh #937
nfahlgren
merged 49 commits into
release-4.0
from
add-parameters-to-mean-adaptive-thresh
Oct 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release-4.0 #937 +/- ##
==============================================
Coverage 100.00% 100.00%
==============================================
Files 161 147 -14
Lines 6840 6640 -200
==============================================
- Hits 6840 6640 -200
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JorgeGtz
added
enhancement
Enhancements to existing features
ready to review
and removed
work in progress
Mark work in progress
labels
Aug 29, 2022
…ub.com/danforthcenter/plantcv into add-parameters-to-mean-adaptive-thresh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adding parameters of block size and offset to both, mean and Gaussian adaptive threshold functions.
This will add flexibility to tune the behavior of the adaptive threshold depending on the image (resolution, size of the objects, and degree of change in brightness).
We have been using these functions as automatic methods, with block size and offset fixed, but that is not an optimal usage of the adaptive thresholds. The important characteristic of these adaptive methods is that they use a different threshold value for each pixel, depending on the value of the pixels in a surrounding block.
Type of update
Is this a:
Associated issues
Additional context
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md