-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] GitHub API request fails for PR with > 300 files change #1432
Labels
Comments
@narutox900 Do you have the fail on error flag set when calling DangerJS? — If yes, and this is still occurring, then we should enhance the core to treat this as a fatal error. |
|
narutox900
changed the title
[BUG] GitHub API request fails silently
[BUG] GitHub API request fails for PR with > 300 files change
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
We are using
danger@^11.2.7
on CircleCI.Since a week before, we started noticing that even though
danger
shows a successful execution, the detail logs show that there's an error with GitHub API. Upon reading GitHub API docs, it states that the limit is 3000 files, however the error shows that the maximum number of files is 300. I haven't been able to find any changelogs related to this problem. Logs from earlier runs on large PRs show thatdanger
can still run properly beforeTo Reproduce
Steps to reproduce the behavior:
danger
on CIExpected behavior
danger
could not run properly.Screenshots
Your Environment
Additional context
Related issues: danger/swift#606, reviewdog/reviewdog#1696
The text was updated successfully, but these errors were encountered: