Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bitrise's ciRunURL underlying env var #1113

Merged
merged 4 commits into from
Feb 22, 2021
Merged

Conversation

rogerluan
Copy link
Contributor

@rogerluan rogerluan commented Feb 18, 2021

Hey 👋

During some debugging process I realized that this env var is probably wrong, based on what it means and what other similar CI files are using as env var values 😊 So here's the fix!

I also added a handy link at the bottom of the file, copying GitLabCI.ts and Travis.ts 📜

EDIT: Resolves #1114

@orta
Copy link
Member

orta commented Feb 18, 2021

Is it possible for people to have older versions of bitrise ( and thus need the old version around?)

@rogerluan
Copy link
Contributor Author

Hey @orta ! Just like in my other PR, both of these env vars (old and new) are also global env vars and not produced by a step, so they should be the same for everyone.

But in this case I don't even think this was ever correct - as the old env var BITRISE_PULL_REQUEST represents just a number (e.g. 1113), not anything else (like the PR link or anything). This might've been a typo or copy'n'paste oversight. The underlying value of this env var was expected to be a number because that's even in the isPR() function a few lines above 😄

So I'd say the answer is no! :)

@orta orta enabled auto-merge February 22, 2021 09:31
@orta orta merged commit 497fac0 into danger:main Feb 22, 2021
@rogerluan rogerluan deleted the patch-2 branch February 22, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Bitrise - Could not add a commit status, the GitHub token for Danger does not have access rights.
2 participants