Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discussion] Drop Swift 5.3 support #523

Closed
417-72KI opened this issue Jun 8, 2022 · 2 comments · Fixed by #524
Closed

[discussion] Drop Swift 5.3 support #523

417-72KI opened this issue Jun 8, 2022 · 2 comments · Fixed by #524

Comments

@417-72KI
Copy link
Member

417-72KI commented Jun 8, 2022

Suggestion

  • Make current version (v3.12.3) to be a last support for Swift 5.3
  • Require Swift 5.4 for next release (v3.12.4 or v3.13.0).
  • Soon, create a new release ( v3.12.5, v3.13.0 or v3.13.1 ) and make it to require Swift 5.5.

Motivation

There is an issue and workaround for building Danger-Swift in Swift 5.3 Docker image (#375, #426).

Fortunately, I tried to run swift build --disable-sandbox -c release in Swift 5.4 image and succeeded!
I think that supporting Swift 5.3 is no longer necessary.

Additionally, dropping Swift 5.4 is more happier for CI because

@417-72KI 417-72KI changed the title [discussion] Drop Swift 5.3 (and 5.4) [discussion] Drop Swift 5.3 (and 5.4) support Jun 8, 2022
@f-meloni
Copy link
Member

f-meloni commented Jun 8, 2022

Thank you for writing this issue :)
I'm totally OK with dropping Swift 5.3, and wait a little bit before dropping Swift 5.4, Ideally I would wait for the new Xcode major to come out and then drop that as well :)

@417-72KI
Copy link
Member Author

417-72KI commented Jun 9, 2022

Thank you for reactions!
I will make a PR to prepare dropping 5.3 only and open a new issue for 5.4 🚀

@417-72KI 417-72KI changed the title [discussion] Drop Swift 5.3 (and 5.4) support [discussion] Drop Swift 5.3 ~~(and 5.4)~~ support Jun 9, 2022
@417-72KI 417-72KI changed the title [discussion] Drop Swift 5.3 ~~(and 5.4)~~ support [discussion] Drop Swift 5.3 support Jun 9, 2022
@417-72KI 417-72KI mentioned this issue Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants