Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache dependencies on CI #467

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Cache dependencies on CI #467

merged 2 commits into from
Sep 27, 2021

Conversation

417-72KI
Copy link
Member

@417-72KI 417-72KI commented Sep 22, 2021

Sometimes CI fails due to fail fetch dependencies from GitHub.
Caching fetched files may suppress wasting time.

↓ has been duplicated with #414 😅
Additionally, macos-latest host runner will use macos-11.
So I unify running CI on macOS host to macos-11 replace macos-latest with macos-10.15.
(Installing danger-js with Xcode 11.7 in macos-11 failed due to Homebrew😅.)

ref: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md#installed-sdks

@417-72KI 417-72KI changed the title [WIP] Cache dependencies on CI Cache dependencies on CI Sep 23, 2021
@417-72KI 417-72KI marked this pull request as ready for review September 23, 2021 05:17
Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@417-72KI
Copy link
Member Author

@f-meloni
Partially duplicated PR (#414) has been merged and conflicted, so I resolved it.
May I merge this by myself if there is no problem?

@f-meloni
Copy link
Member

@f-meloni
Partially duplicated PR (#414) has been merged and conflicted, so I resolved it.
May I merge this by myself if there is no problem?

sure :)

@417-72KI 417-72KI merged commit 4797bbb into danger:master Sep 27, 2021
@417-72KI 417-72KI deleted the cache-dependencies-on-ci branch September 27, 2021 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants