Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Add support for MQTT Integration #17

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Conversation

apoc4lyps
Copy link
Contributor

Add Support for Octoprint MQTT Integration in addition to the Octoprint API (https://plugins.octoprint.org/plugins/homeassistant/)

@dangreco
Copy link
Owner

I've looked over the implementation and it looks good -- thanks! However, quick question from someone who doesn't use OctoPrint via MQTT: are the entity ID suffixes for OctoPrint x MQTT the same for every user? Or would they have to configure their MQTT sensors to match the format specified in the code?

@Jan-Ka
Copy link
Contributor

Jan-Ka commented Feb 18, 2021

Entity ID suffixes from OctoPrint-HomeAssistant are static (i.e. same for every user) as they are read through MQTT Discovery.

Example Print Status: https://github.com/cmroche/OctoPrint-HomeAssistant/blob/5a8afe732671e7eb40c41ea6051c52caec6e0094/octoprint_homeassistant/__init__.py#L249

Pretty sure, without altering the Plugin Implementation, there's no easy way to change these.

@dangreco dangreco merged commit 9fde34d into dangreco:master Feb 18, 2021
@dangreco
Copy link
Owner

Merged! Thanks again guys!!

@apoc4lyps apoc4lyps mentioned this pull request Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants