Focus Atom application when text-synced from chrome browser #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, and sorry for the delay, I will take a look during the weekend! |
|
I'm working for improving package activation time(faster package activation). https://github.com/t9md/atomic-chrome-atom/blob/experiment/lib/atomic-chrome.coffee If you are OK for that I can send separate PR for that. Or hope you apply this change by yourself. |
|
Very sorry for the delay, I completely forgot about this PR 😓 |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is we discussed in danhper/atomic-chrome#28
But it reveals it's achievable only by atomic-chrome-atom side.
And I could see slight activation time reduction from 40ms/avg to 30ms/avg by deferred require for ws-handler.
I can make it config option (e.g.
automaticallyActivateAtomWindow), but IMO this is all user's expectation so didn't do that.How do you think?