Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Surge (378540) freezes and artifacts #150

Closed
AwesamLinux opened this issue Oct 11, 2019 · 22 comments
Closed

The Surge (378540) freezes and artifacts #150

AwesamLinux opened this issue Oct 11, 2019 · 22 comments

Comments

@AwesamLinux
Copy link

AwesamLinux commented Oct 11, 2019

Describe the bug
The Surge works fine with ACO until the second area (where the actual game begins), then the game is practically unplayable because it freezes frequently a couple of seconds. (as was mentioned on ValveSoftware/Proton#410)

Notice the performance here (ACO left)
llvm_aco

There is also artifacts that look like lines that shoot accross the screen, as pictured below:
surge

What I think is happening here is that it is the rendering of the sparks from the flying drone robots are glitching. Also these flying drones are not present in the introduction area, so maybe that is why there was no problems in there.

I have also tried with RADV_PERFTEST=llvmvs but that made no difference.

steam-378540-proton-4.11-7-aco.log.zip
steam-378540-proton-4.11-7-llvm.log.zip

RenderDoc capture:
Renderdoc 1.4 captures, providing two. Both grabbed using LLVM because I could not get it to capture with ACO.

https://drive.google.com/open?id=1naduFlnFnya1Tdvnv78lNhxfRCGG23KM
https://drive.google.com/open?id=17Hz_CHwn8MlIHv7BTHcTuayvdpJ5YtHf

The first one is of the overall scene. And the second one with a close look at those flying drones and their sparks.

System information:

  • GPU: RX VEGA 56
  • GPU Driver: 19.1.0+aco+git1570636576-246f50f2c13-1bionic1 (Valves PPA)
  • Kernel version: 5.4.0-050400rc2-lowlatency
  • Distro version: Linux Mint 19.2 Tina (64 bit) (Cinnamon)
  • Proton version: 4.11-7

system_info.txt

Additional context
I believe this problem did not exist when I tried it with ACO back in Jul 10 (I posted in the benchmark thread). I'm pretty sure I had tried this area too of the game without issues.

@pingubot
Copy link

I can confirm the issue.And it is definitively a regression, the surge worked fin in the past, not so long ago. I also have a vega 56.

@AwesamLinux
Copy link
Author

AwesamLinux commented Oct 29, 2019

System Information

  • GPU: RX VEGA 56
  • GPU Driver: 19.3.0~git1910291605.f9ad73cdfd2~b~mesaaco0 (ppa:ernstp/mesaaco)
  • Kernel version: 5.4.0-050400rc5-lowlatency
  • Distro version: Linux Mint 19.2 Tina (64 bit) (Cinnamon)
  • Proton version: 4.11-7

Retest Compatibility Report

Tried this with the latest driver from ernstp PPA, and now the performance is good. But the graphical glitches remains, clouds flickering and lines/artifacts.

Here is a short screen capture of this:
surge.mp4.zip
system_info.txt

@pingubot
Copy link

I can confirm that perf issue is fixed with fe930ad, but the flickering issue which is shown in @AwesamLinux video is there. This also is a regression, the surge worked perfect in the past.

@pingubot
Copy link

pingubot commented Nov 1, 2019

Sadly still an issue with commit 3b06b51

@daniel-schuermann
Copy link
Owner

We had some similar issue in Shader of the Tomb Raider. Would you check if the issue is still present with the current driver? If so, would you check if the issue is also present in upstream and try to get a capture of it?
I tested both provided captures, and one of them just hangs with LLVM and with ACO while the other renders the same for me.

@pingubot
Copy link

pingubot commented Nov 11, 2019

@daniel-schuermann After removing shader caches i was able to start the game with the newest version. I still get the strange flickering, but i also get it with: RADV_PERFTEST=llvm %command%.
In addition i also see the issue with my distro provided mesa radv 19.2.2 .

Edit: I also see the issue with amdpro (19.30) and amdvlk (2019q36)

@AwesamLinux
Copy link
Author

AwesamLinux commented Nov 11, 2019

System Information

  • GPU: RX VEGA 56
  • Kernel version: 5.4.0-050400rc7-lowlatency
  • Distro version: Linux Mint 19.2 Tina (64 bit) (Cinnamon)
  • Proton version: 4.11-8

system_info.txt

Retest Compatibility Report

I tried the game again with these two drivers:

  • GPU Driver: 20.0~git1911111930.57acf9~oibaf~b (ppa:oibaf/graphics-drivers)
  • GPU Driver: 19.1.0+aco+git1573122507-2e64afa5e39-1bionic2 (ppa:valve-experimental/mesa-bionic)

(Hope these are recent enough, I always run into issues trying to compile the drivers myself 😄)

I was able to capture with ACO enabled this time, this is how it looked for me:

steam-378540-proton-oibaf-4.11-8-aco.log.zip
steam-378540-proton-oibaf-4.11-8-llvm.log.zip
steam-378540-valve-proton-4.11-8-aco.log.zip
steam-378540-valve-proton-4.11-8-llvm.log.zip

With LLVM I did not see any problems, the game was rendered correctly. But with ACO there is glitches like these:
Screenshot from 2019-11-11 23-52-21
☝️ There is a box in a darker shade to the left
Screenshot from 2019-11-12 00-14-13
☝️ The dust cloud to the right has no transparency

Captures:
https://drive.google.com/open?id=1OLkNnnYfaREoWkN8aphpRlGJjdyHZR3L
https://drive.google.com/open?id=1j5wS5TJxUF7_qqTpVXAq6yXvSF8X8j16

@pingubot
Copy link

@AwesamLinux is that grey bar in your first screenshot also changing the size and flickering ?

@AwesamLinux
Copy link
Author

@pingubot yea it flickers and changes in size when looking around.

@pingubot
Copy link

pingubot commented Nov 12, 2019 via email

@daniel-schuermann
Copy link
Owner

Unfortunately, both renderdoc captures give me the exact same picture with LLVM and ACO. This can mean anything... It could be baked textures in the capture, a mesa regression or DXVK. Best way to figure what it is would be to find the working combination and bisect from there.

@doitsujin
Copy link

FWIW I cannot reproduce the problem on Polaris.

@AwesamLinux
Copy link
Author

AwesamLinux commented Jan 7, 2020

I have now a RX 5700 GPU and with this setup I'm seeing same glitch using both LLVM and ACO with Proton 4.11-11. But the problem goes away if hitting escape once to bring up the pause/options menu and then resuming the game!

The glitch occurs at the area where the actual gameplay starts:
20200107220209_1
☝️ Here is the same glitch using LLVM, shadow like bar that flicker accross the screen.

I did some testing to try and narrow this down

Proton DXVK Compiler Worked?
4.2-9 1.2.1 ACO SUCCESS
4.2-9 1.2.1 LLVM SUCCESS
4.2-9 1.5 ACO SUCCESS
4.2-9 1.5 LLVM SUCCESS
4.11-11 1.2.1 ACO FAIL
4.11-11 1.2.1 LLVM FAIL
4.11-11 1.3.4 ACO FAIL
4.11-11 1.3.4 LLVM FAIL
4.11-11 1.4.5 ACO FAIL
4.11-11 1.4.5 LLVM FAIL
4.11-11 1.4.6 ACO FAIL
4.11-11 1.4.6 LLVM FAIL
4.11-11 1.5 ACO FAIL
4.11-11 1.5 LLVM FAIL

So the issue does not occur at all with Proton 4.2-9, but with 4.11-11 it occurs regardless of DXVK version or if using ACO or LLVM. I'm thinking ACO is not the problem considering I'm seeing this with LLVM too with the RX 5700

System Information

  • GPU: RX 5700
  • GPU Driver: Mesa 20.0.0-devel (git-3bd4bcd 2020-01-07 bionic-oibaf-ppa)
  • Kernel version: 5.3.18-050318-lowlatency
  • Distro version: 19.3 Tricia (64 bit) (Cinnamon)
  • Proton version: 4.11-11

steam-378540-logs.zip
system_info.txt

@pingubot
Copy link

pingubot commented Jan 8, 2020

@AwesamLinux many thx for your test. I also don't notice the black bars anymore using proton 4.2.9 instead of 4.2.11 (dxvk version kept identical) . But with latest aco (7b444ba) now have issues with sandstorms. Can you see if you also have graphical corruptions (the sky is flickering with grey squares, hard to describe) if a sandstorm is happening ? Sadly i am not able to screenshot the issues, as it doesn't show up on a screenshot. That issues does not show up with radv llvm or amd-pro.

@NTMan
Copy link

NTMan commented Jan 8, 2020

Folks, please see my report
https://gitlab.freedesktop.org/mesa/mesa/issues/2267

With Proton 4.2.9 the walls and characters are gone
Demonstration: https://youtu.be/8uQLsVwvzQE

@pingubot
Copy link

pingubot commented Jan 8, 2020 via email

@NTMan
Copy link

NTMan commented Jan 8, 2020

Can you try Proton 4.2.9 but Use a more up2date dxvk as we do ? For me 4.2.9 works beside the sandstorm issue

Which DXVK do you use? latest?

@pingubot
Copy link

pingubot commented Jan 8, 2020 via email

@AwesamLinux
Copy link
Author

@pingubot I tried again with the very latest Oibaf PPA from today, but could not see any glitches with the sky/sandstorms even with ACO enabled.

  • GPU: RX 5700
  • GPU Driver: Mesa 20.0.0-devel (git-472593e 2020-01-08 bionic-oibaf-ppa)
  • Kernel version: 5.3.18-050318-lowlatency

Assuming 7b444ba is included in that driver, then maybe the sky/sandstorm glitch only occurs with Vega 🤔

@daniel-schuermann
Copy link
Owner

This repo here contains a couple of optimizations, so it might very well be the case that we broke something. Could someone provide a capture? Then, I can try to figure what went wrong :)

@NTMan
Copy link

NTMan commented Jan 8, 2020

@daniel-schuermann please look my report https://gitlab.freedesktop.org/mesa/mesa/issues/2267#note_378824

@AwesamLinux
Copy link
Author

I'm closing this issue, as the only remaining problem is the flickering shadow and it appears to be related to Proton and not ACO.

Because it occurs regardless of using LLVM or ACO on new Proton versions, and does not occur with old Proton 4.2-9 as mentioned here ValveSoftware/Proton#410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants