Colorful caterpillars #43
Conversation
-add colour parameter/option -add new section to plot with colours (diff syntax) -in the study-coloured section, relabel legend
-Add cb option like in orchaRd::orchard_plot -recolours at end using same method as orchaRd::orchard_plot -colourblind friendlieness is default
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
- Coverage 52.75% 51.21% -1.55%
==========================================
Files 11 11
Lines 707 740 +33
==========================================
+ Hits 373 379 +6
- Misses 334 361 +27
☔ View full report in Codecov by Sentry. |
|
Thanks Matt. Can you provide a little example code and figure to demonstrate what you mean. Reason being is that, I just introduced one option to change colours a few weeks ago and I just want to be sure the logic doesn't conflict. Cheers! |
Hi Dan. Oh sorry I didn't know you'd already implemented this one. If that's the case then obviously let's just go with yours as I assume it's cleaner than mine and more in line with your style. |
|
Lokos ok to merging |
Added options to colour effect sizes in caterpillars() by study, defaulting to color-blind friendly palette. ('colour' and 'cb' parameters). I used essentially the 'colour' parameter as in orchard_plot for equivalency but it might be a little confusing given the other colour parameters also in the function. But maybe not. Feel free to rename if you want. Cb also works essentially the same as in orchard_plot.
I wanted to stick to one plotting function but found it tricky to find a solution in ggplot syntax that worked for both no colouring (well, yellow estimates, green errors) and colouring by study. Perhaps something to consider for a future improvement but does the job for now.