Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i want to customise node. is it possible ? #90

Closed
vivek1623 opened this issue Jul 18, 2018 · 10 comments

Comments

@vivek1623
Copy link

@vivek1623 vivek1623 commented Jul 18, 2018

i want to use my custom node in graph. is it possible ?

@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Jul 18, 2018

Hello there @vivek1623, yes you can use some other svg as a node, just look in the official documentation for the configuration node.svg and you'll see how you can achieve it. This was raised here #36

@vivek1623

This comment has been minimized.

Copy link
Author

@vivek1623 vivek1623 commented Jul 18, 2018

Using svg is fine. But I want to customize node using html.

@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Jul 18, 2018

Oh ok. That's a bit vague can you give an example or a simple use case so that I'm able to understand you better? But to be clear the aim of this component is to use svg only for graph data visualizations.

@vivek1623

This comment has been minimized.

Copy link
Author

@vivek1623 vivek1623 commented Jul 19, 2018

i want to create a workflow diagram (bot builder) for intent and entity, where user can add , update and delete the node. each node has some title, type, and other information. it is very similar to botbuilder for kore.ai. your libaray is giving me a best base to start this module but for ui perspective, i need to change node.

@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Jul 19, 2018

Hmm I see @vivek1623 . So I that a small POC on this where I'm enabling the nodes to receive custom HTML and then I inject it within a tag. So this basically gives clients the power to do whatever they want in the node label are with HTML and CSS, you can write specific presentation components to display in that area. Below the sample with the html are in the node label and the inspector focused on the element:

screenshot from 2018-07-19 16-02-21

But in my opinion, this seems a bit overkill, and at this point, react-d3-graph has already some in progress work items, so we are out of resources here.

@vivek1623

This comment has been minimized.

Copy link
Author

@vivek1623 vivek1623 commented Jul 20, 2018

but graph are very near in default position. is there way to spread it. my flow diagram should look like https://github.com/DrummerHead/react-flow-diagram this.

@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Jul 25, 2018

I'm not able to access the link you shared. Still, if I understood correctly you want nodes to be spread, that is possible since you can set a position for each node placing them apart from each other.

@stale

This comment has been minimized.

Copy link

@stale stale bot commented Aug 24, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 24, 2018
@LonelyPrincess

This comment has been minimized.

Copy link
Collaborator

@LonelyPrincess LonelyPrincess commented Aug 31, 2018

Hi there! I'm interested in this feature too, and I already started working on it.

Right now I can pass a view property to each node, which will take a JSX view as a value. This will allow us to define a completely customized node, such as the author of this issue wanted. The POC @danielcaldas published here was a big help in order to achieve this. I'm hoping to submit a PR with the changes by next week.

@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Sep 25, 2018

Closing this with release 2.0.0-rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.