Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to make link cross multiple points across its route from source node to target node #378

Merged

Conversation

lironhl
Copy link
Contributor

@lironhl lironhl commented Oct 8, 2020

closes #373 (Even though additional functionality to the behavior mentioned in the issue may be added in the future).

This PR adds the ability to describe the Link route from its source node to target node more precise way.

The behavior can be seen in this screenshot:
link-breakPoints

@lironhl lironhl force-pushed the feature/link.breakPoints_option branch from 67ab356 to 15182e7 Compare October 8, 2020 13:16
Copy link
Owner

@danielcaldas danielcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks a lot for the changes, the feature is looking good. Before moving forward there are some API decisions we need to make and some other small comments I left.

docs/DOCUMENTATION.md Outdated Show resolved Hide resolved
src/components/link/link.helper.js Outdated Show resolved Hide resolved
src/components/link/link.helper.js Show resolved Hide resolved
src/components/link/link.helper.js Outdated Show resolved Hide resolved
test/graph/graph.builder.spec.js Outdated Show resolved Hide resolved
test/link/link.helper.spec.js Show resolved Hide resolved
@lironhl lironhl force-pushed the feature/link.breakPoints_option branch from 0f6dd71 to e282191 Compare October 16, 2020 14:13
@lironhl
Copy link
Contributor Author

lironhl commented Oct 24, 2020

@danielcaldas I think this PR is ready to be merged.

@lironhl lironhl mentioned this pull request Nov 13, 2020
Copy link
Owner

@danielcaldas danielcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@danielcaldas danielcaldas merged commit 30304b7 into danielcaldas:master Nov 17, 2020
@lironhl lironhl deleted the feature/link.breakPoints_option branch November 17, 2020 14:31
danielcaldas added a commit that referenced this pull request Nov 17, 2020
…:local: script. Add breakPoints example to small.data.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bendable links
2 participants