-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cordova Plugin #23
Comments
Quick instructions to play around with this: npm install -g cordova
git clone https://github.com/vulume/Cordova-DBCamera
cordova create dbcamera-test
cd dbcamera-test
cordova platform add iOS
cordova plugin add ../Cordova-DBCamera
open platforms/ios/*.xcodeproj |
Hi @mkcode , Daniele |
Sounds great. Btw - I evaluated every IOS camera related cocoapod before deciding that dbcamera was the best so thank you for creating this. Looking forward to see what changes in the upcoming release. There are a few changes I will make shortly to the cordova plugin, mainly using an already compiled .a file instead of source files - will avoid having to set the gnu99 dialect. Will do this when I pull in the next release. Also, I was forced to temporarily disable passing the metadata back to the JS callback. Cordova JSONSerializes the metadata NSdictionary - but it breaks on iPhone5Ss. It looks like the 5S and the 5 send back different metadata - and I don't have a 5S to debug this on. I'd like to look into this more some point soon. Cheers |
Thanks a lot @mkcode. You can take a look to the master, for a preview. I'll just add a few small changes and more precise documentation. |
Lot's of good changes. The new image cropping bounds are exactly what I wanted. Look's like I'll need to update the Container related code in the plugin. I spent some time yesterday working on a update script that makes the plugin from the cocoapod spec, with compiling the source for the plugin. Hopefully, it won't be just me who is will update the project. I'll get this out this week. |
I've done a name refactoring; all the controllers have ViewController suffix. This is because i've created a custom settings of alloc option (in the Profiler) to check if the app has some retain cycle. And fortunately it's ok. No retain cycles ;) |
The completion block within the container, handles the cameraView. This avoid the init of the cameraViewController in the init method of the container (solution for a old pull request i've accepted). In the block you can change the properties values of the cameraView. |
Plugin is working nicely at version 2.0 :-) I ended up making this repo to manage updating https://github.com/mkcode/cocoapod-to-cordova |
Great! I've merged the pull request! |
Hi @mkcode , |
Thanks for the update. The cordova plugin is up to date with this change. The default grid view is perfect for my use case, but adding a way to easily customize this is a great change. I'm considering the best way to handle locking the orientation to portrait. I did this in the cordova plugin: vulume/Cordova-DBCamera@34d7a40...9e8625b This forces portrait mode for the lifetime of the NavController, but I questioned when I implemented this if should add this to the individual ViewControllers and submit a PR to this project. Currently - the views don't support landscape, so perhaps they should be locked into portrait mode in each ViewController - then they could be updated on an individual basis if they do support landscape in the future. I'm also not sure of the best practice for this - to lock the orientation in the NavController or the ViewControllers. |
Hi @mkcode , |
Thank you so much. You both @mkcode , @danielebogo have done really a great work. Can you please help me out regarding how to use these plugins in DevExpress ? As my application works on DevExpress + AngularJS + Cordova, and I want to access camera properties like Grids, Tilt Angle, orientation. Please help me out. |
@danielebogo thanks for creating such a great plugin. Any help would be highly appreciated. |
Hi @mkcode, I would like to use your plugin via build.phonegap. What do I have to write in the config.xml file to install your plugin through the phonegap build website? Thanks |
@dalmendray - the plugin title is I no longer maintain this project. Feel to use it, but at your own risk. |
@danielebogo - Just a note, that I am no longer contributing to this project. Let me know if I can help transition this work in any way. |
Hi @danielebogo
I created an Apache Cordova wrapper for this project here: https://github.com/vulume/Cordova-DBCamera
Please check it out and let me know what you think. Contributions are more than welcome. Let me know if I can better accredit your work anywhere as well.
Cheers
The text was updated successfully, but these errors were encountered: