Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxBackupFileCount always equal 1 #61

Closed
zinpub opened this issue Sep 16, 2022 · 1 comment
Closed

MaxBackupFileCount always equal 1 #61

zinpub opened this issue Sep 16, 2022 · 1 comment

Comments

@zinpub
Copy link

zinpub commented Sep 16, 2022

Maybe must be Max?

constructor TLoggerProFileAppenderBase.Create(aMaxBackupFileCount: Integer; aMaxFileSizeInKiloByte: Integer; aLogsFolder: string;
aFileAppenderOptions: TFileAppenderOptions; aLogFileNameFormat: string; aLogFormat: string; aEncoding: TEncoding);
begin
inherited Create(ALogFormat);
fLogsFolder := aLogsFolder;
fMaxBackupFileCount:= Min(1, aMaxBackupFileCount);
fMaxFileSizeInKiloByte := aMaxFileSizeInKiloByte;
fLogFileNameFormat := aLogFileNameFormat;

@luebbe
Copy link
Contributor

luebbe commented Sep 19, 2022

You're obviously right. This is a result of #60 where I wrote wrong example code.

luebbe added a commit to luebbe/loggerpro that referenced this issue Dec 14, 2022
danieleteti added a commit that referenced this issue Dec 14, 2022
@zinpub zinpub closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants