Add optional support for calling Tornado coroutines #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 15, 2017 16:14
Signed-off-by: jeffrand <jeffr@seatgeek.com>
Signed-off-by: jeffrand <jeffr@seatgeek.com>
Signed-off-by: jeffrand <jeffr@seatgeek.com>
… arguments Signed-off-by: jeffrand <jeffr@seatgeek.com>
|
Totally forgot to mention this, but can you please update the README with usage instructions? |
Closed
|
Will do!
On Wed, Jun 21, 2017 at 5:38 PM Daniel Martins ***@***.***> wrote:
Totally forgot to mention this, but can you please update the README with
usage instructions?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACckkW7mExmVQXIoHZ77dwnGRoWkeUkeks5sGY1HgaJpZM4N7umk>
.
--
- Jeff
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a big fan of your library and I've been using my own fork over here at SeatGeek, so I figured I'd contribute. We use Tornado as our webserver and use this code to circuit break asynchronous code.
This change adds optional support for Tornado coroutines. This should be a backwards compatible change.
I did this by:
CircuitBreaker.__call__to optionally take a keyword argument__pybreaker_call_async, which will callCircuitBreaker.call_asyncifTrue. The keyword argument is sufficiently verbose to hopefully avoid collision with existing keyword argumentsCircuitBreaker.call_asyncCircuitBreakerState.call_asyncThis also has tests that cover the parts that I added. It also fixes a bug if
redisis not present.