Provide acq_name and acq_source to append method when filtering #999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The channel group acquisition properties of a filtered MDF aren't copied across for MDF versions 4.20 and greater. See the example below for a minimal reproducible example:
I would expect this to print
However instead we see
This appears to be due to the call to _append_column_oriented for 4.20 version MDFs, which creates multiple groups. However the
filter
method only updates the acquisition properties for the first group.A simple fix is to pass the
acq_source
andacq_name
to theappend
method. However I am unsure if this is the proper solution. Perhaps the current behavior is intended? Or perhaps this change has further ramifications?