Hyperbolic and parabolic setups in set_binary #443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
new physics; resolves #302
Description:
Added the ability to handle parabolic and hyperbolic orbits in the set_binary routine, which resolves #302. This does not replace the functionality in set_flyby because by default this routine uses the true anomaly to set the position in the orbit. which is not terribly helpful for unbound orbits. However, it allows one to simply set e >= 1 in any setup calling set_binary and things will at least work.
Testing:
manual setup of point mass binary using SETUP=binary:
Did you run the bots? no
Did you update relevant documentation in the docs directory? no