Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperbolic and parabolic setups in set_binary #443

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Conversation

danieljprice
Copy link
Owner

Type of PR:
new physics; resolves #302

Description:
Added the ability to handle parabolic and hyperbolic orbits in the set_binary routine, which resolves #302. This does not replace the functionality in set_flyby because by default this routine uses the true anomaly to set the position in the orbit. which is not terribly helpful for unbound orbits. However, it allows one to simply set e >= 1 in any setup calling set_binary and things will at least work.

Testing:
manual setup of point mass binary using SETUP=binary:

~/phantom/scripts/writemake.sh binary > Makefile
make setup
make
-> edit .setup file to give e=1 or e>1 and play with angles

Did you run the bots? no

Did you update relevant documentation in the docs directory? no

@danieljprice danieljprice changed the title Hyperbolic Hyperbolic and parabolic setups in set_binary Jul 3, 2023
@danieljprice danieljprice merged commit 4fb4649 into master Jul 3, 2023
@danieljprice danieljprice deleted the hyperbolic branch July 3, 2023 11:48
@Francyrad
Copy link

I am infinitely grateful! I will run a test immediately and compare the results with StarSmasher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to create a stellar collision or a fly by between 2 stars.
2 participants