Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_orbit: Add arbitrary stars on arbitrary orbits; add stars orbiting the black hole to a grdisc simulation; cleanup of SETUP=binary #545

Merged
merged 17 commits into from
May 18, 2024

Conversation

danieljprice
Copy link
Owner

@danieljprice danieljprice commented May 17, 2024

Type of PR:
new setup

Description:

  • added set_orbit functionality for setting up two body orbits using different parameter sets (current options are aeiOwf, flyby parameters and direct specification of position and velocity)
  • add helper routines to set up multiple stars, to reduce lines of code needed when adding multiple stars
  • fix bug where Mstar would be zero by default in the .setup file when rewritten from set_star routines
  • added ability to add up to 10 stars orbiting the black hole to grdisc setup for quasi-periodic-eruption calculations
  • cleanup of SETUP=binary to use new set_orbit and set_stars routines

Testing:

make SETUP=grdisc setup
./phantomsetup qpe

set nstars >= 1

./phantomsetup qpe
./phantom qpe.in

Did you run the bots? no

Did you update relevant documentation in the docs directory? no

@danieljprice danieljprice changed the title GR disc with stars set_orbit: Add arbitrary stars on arbitrary orbits; add stars orbiting the black hole to a grdisc simulation; cleanup of SETUP=binary May 17, 2024
@danieljprice danieljprice merged commit bcfadb0 into master May 18, 2024
180 checks passed
@danieljprice danieljprice deleted the grdisc-with-stars branch May 18, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant