Ever needed to use a global variable in Rails? Ugh, that's the worst. If you
need global state, you've probably reached for Thread.current
. Like this:
def self.foo
Thread.current[:foo] ||= 0
end
def self.foo=(value)
Thread.current[:foo] = value
end
Ugh! I hate it. But you gotta do what you gotta do...
Everyone's worrying about concurrency these days. So people are using those
fancy threaded web servers, like Thin or Puma. But if you use Thread.current
,
and you use one of those servers, watch out! Values can stick around longer
than you'd expect, and this can cause bugs. For example, if we had this in
our controller:
def index
Thread.current[:counter] ||= 0
Thread.current[:counter] += 1
render :text => Thread.current[:counter]
end
If we ran this on MRI with Webrick, you'd get 1
as output, every time. But if
you run it with Thin, you get 1
, then 2
, then 3
...
Add this line to your application's Gemfile:
gem 'request_store'
And change the code to this:
def index
RequestStore.store[:foo] ||= 0
RequestStore.store[:foo] += 1
render :text => RequestStore.store[:foo]
end
Yep, everywhere you used Thread.current
just change it to
RequestStore.store
. Now no matter what server you use, you'll get 1
every
time: the storage is local to that request.
A Railtie is added that configures the Middleware for you, but if you're not using Rails, no biggie! Just use the Middelware yourself, however you need. You'll probably have to shove this somewhere:
use RequestStore::Middleware
- Fork it
- Create your feature branch (
git checkout -b my-new-feature
) - Commit your changes (
git commit -am 'Add some feature'
) - Push to the branch (
git push origin my-new-feature
) - Create new Pull Request
Don't forget to run the tests with rake
.