Cobertura report shows NaN for all complexities

[briangardner]

Expected Behavior
Creating the Cobertura report type should include Cycolmatic Complexity, and highlight Risk Hotspots.

Observed Behavior

• Step 1: Run dotnet test --collect:"XPlat Code Coverage" --settings .\coverlet.runsettings.xml on a .Net Core 3.0 project
  • coverlet.runsettings.xml:

  <?xml version="1.0" encoding="utf-8" ?>
  <RunSettings>
    <DataCollectionRunSettings>
      <DataCollectors>
        <DataCollector friendlyName="XPlat code coverage">
          <Configuration>
            <Format>cobertura</Format>
            <Exclude>[*.Tests]*</Exclude>
            <IncludeTestAssembly>false</IncludeTestAssembly>
          </Configuration>
        </DataCollector>
      </DataCollectors>
    </DataCollectionRunSettings>
  </RunSettings>
  

• Step 2: run reportgenerator "-reports:*\TestResults\*\*.xml" "-targetdir:coveragereport" -reporttypes:""HTMLInline_AzurePipelines;Cobertura" on a .Net Core 3.0 project,

The HTML Report shows cyclomatic complexity numbers, and risk hotspots as expected. The Cobertura.xml file has complexity="NaN" for every package, class, and method. And since all complexities are NaN, no Risk Hotspots show.

[eddynaka]

@danielpalme , I was looking at this and every place in CoberturaReportBuilder that prints complexity is pointing to NaN. Is it on purpose? Can i create a PR adding the logic to fill that value?

[danielpalme]

It's not as easy as it may seem.
ReportGenerators supports several input formats. Not every format contains the complexity metric.
ReportGenerator currently only tracks the metrics for each method (if available).
So adding this to the method elements should be doable.

All the other elements require quite a lot of work.
You'll have to take into account, that information is not available in all formats and that you have to support merging of results as well.

[eddynaka]

I will try some stuff and we can check if that will work. At least, for my case, I had the values in the xml.

…

________________________________ From: Daniel Palme <notifications@github.com> Sent: Sunday, August 2, 2020 5:47:42 AM To: danielpalme/ReportGenerator <ReportGenerator@noreply.github.com> Cc: Eddy Nakamura <Eddy.Nakamura@microsoft.com>; Comment <comment@noreply.github.com> Subject: Re: [danielpalme/ReportGenerator] Cobertura report shows NaN for all complexities (#367) It's not as easy as it may seem. ReportGenerators supports several input formats<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdanielpalme%2FReportGenerator%23supported-input-and-output-file-formats&data=02%7C01%7CEddy.Nakamura%40microsoft.com%7Ce97f10081c1c4237de4108d836c0b8bb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637319548656125791&sdata=%2BQEy%2BJ%2BdcbhD7yBVxelZbBg5phpF%2Fdcd%2F74E2Dv1qPE%3D&reserved=0>. Not every format contains the complexity metric. ReportGenerator currently only tracks the metrics for each method (if available). So adding this to the method elements<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdanielpalme%2FReportGenerator%2Fblob%2Fmaster%2Fsrc%2FReportGenerator.Core%2FReporting%2FBuilders%2FCoberturaReportBuilder.cs%23L96&data=02%7C01%7CEddy.Nakamura%40microsoft.com%7Ce97f10081c1c4237de4108d836c0b8bb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637319548656125791&sdata=aX%2B63Z1NaqcjtpPmsMzpyKUqTv7oIjatW%2BHcwTqP6Bo%3D&reserved=0> should be doable. All the other elements require quite a lot of work. You'll have to take into account, that information is not available in all formats and that you have to support merging of results as well. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdanielpalme%2FReportGenerator%2Fissues%2F367%23issuecomment-667646739&data=02%7C01%7CEddy.Nakamura%40microsoft.com%7Ce97f10081c1c4237de4108d836c0b8bb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637319548656135790&sdata=0VVsjDbgQyzulveCHpFk3wXNsqrIxNHZqn5lwsAHLnk%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD3S2ZHA6KVZPXJ5ZPMQOLLR6UR25ANCNFSM4PQJJ4LA&data=02%7C01%7CEddy.Nakamura%40microsoft.com%7Ce97f10081c1c4237de4108d836c0b8bb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637319548656135790&sdata=Uy1ibgNoMQMIY2%2FpGt74OSVxbmPQK08SVtWMI0u9Bu4%3D&reserved=0>.

[eddynaka]

@danielpalme , i opened the PR #369. Right now, with this changes i already added the complexity to:

• method
• file

And, trying to figure out how to add to package / root.

[danielpalme]

Will test this in several scenarios. But may take a while, since I'm on vacation.

[danielpalme]

Merged this into develop branch.
Next release will contain your changes.