Add support for reading report arguments from .netconfig #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The feature was explicitly added as a fallback for missing arguments, but that can be changed if desired. That is, none of the config-driven values are taken into account if the same argument has already been provided (via CLI or MSBuild). It might be worth exploring whether some configurations could actually augment the provided arguments (i.e. plugins, filters?). So that the configured ones are added to the ones in the CLI/MSBuild args. |
kzu
added a commit
to dotnetconfig/dotnet-config
that referenced
this pull request
Aug 27, 2020
Most shouldn't need strong-named assemblies, but some might so, we will just strong name ¯\_(ツ)_/¯. Been fighting for many hours to workaround it using StrongNamer and what-not for danielpalme/ReportGenerator#374 without success. So, just declare defeat and move on.
|
Ok, I think this is ready for review now :) |
The http://dotnetconfig.org/ format allows unifying configuration with other .NET core tools, making it easier to maintain multiple tool settings in a centralized fashion. By leveraging the format, ReportGenerator gains: * Simplified command line args in CI scripts (just run without parameters most of the time) * Support for hierarchical configurations * Standard way of updating and managing those configurations, via the `dotnet config` tool, such as `dotnet config --add reportgenerator.reporttype Html` The configuration is shared uniformly between the CLI and MSBuild task, for consistency. Updated the documentation too to showcase the new functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http://dotnetconfig.org/ format allows unifying configuration with
other .NET core tools, making it easier to maintain multiple tool settings
in a centralized fashion.
By leveraging the format, ReportGenerator gains:
most of the time)
dotnet configtool, such asdotnet config --add reportgenerator.reporttype HtmlThe configuration is shared uniformly between the CLI and MSBuild task, for
consistency. Updated the documentation too to showcase the new functionality.