Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#445: Added support for better custom logging #446

Merged
merged 1 commit into from
Sep 10, 2021
Merged

#445: Added support for better custom logging #446

merged 1 commit into from
Sep 10, 2021

Conversation

danielpalme
Copy link
Owner

No description provided.

@danielpalme danielpalme mentioned this pull request Sep 8, 2021
Closed
@RoadTrain
Copy link

RoadTrain commented Sep 8, 2021 •
edited
Loading

Looks good!
If you're interested, I've experimented with this myself: RoadTrain@96deffc

It's pretty similar to your solution, though maybe you can pull something from it.
I used a typed delegate instead of Action, but maybe that's an overkill.
Also, I think your approach with formatting inside the implementation (as opposed to my approach of sending args to delegate) is better.

Anyway, your solution will be enough for my needs (and hopefully others'), so LGTM.

@danielpalme danielpalme merged commit 4433b60 into master Sep 10, 2021
@danielpalme danielpalme deleted the logging branch September 11, 2021 09:36
@danielpalme
Copy link
Owner Author

I merged my changes.
The new API will be available in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielpalme @RoadTrain