File refinement/monkeypatch use TypeError

danielpclark · Sep 12, 2017 · 46bd9c0 · 46bd9c0
1 parent 144941e
commit 46bd9c0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/faster_path/optional/monkeypatches.rb b/lib/faster_path/optional/monkeypatches.rb
@@ -7,7 +7,7 @@ def self._ruby_core_file!
       ::File.class_eval do
         def self.basename(pth, ext = '')
           pth = pth.to_path if pth.respond_to? :to_path
-          raise TypeError unless pth.is_a? String
+          raise TypeError unless pth.is_a?(String) && ext.is_a?(String)
           FasterPath.basename(pth, ext)
         end
 

diff --git a/lib/faster_path/optional/refinements.rb b/lib/faster_path/optional/refinements.rb
@@ -5,7 +5,7 @@ module RefineFile
     refine File do
       def self.basename(pth, ext = '')
         pth = pth.to_path if pth.respond_to? :to_path
-        raise TypeError unless pth.is_a? String
+        raise TypeError unless pth.is_a?(String) && ext.is_a?(String)
         FasterPath.basename(pth, ext)
       end