Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle camel-case options correctly #197

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

larsjkr
Copy link
Contributor

@larsjkr larsjkr commented Oct 30, 2023

Resolves #196

The Problem was that Intl.DateTimeFormat expects e.g. timeZone, but the current implementation passes e.g. timezone instead.

// currently
new Intl.DateTimeFormat(options.locale, { timezone: 'America/New_York' });

// after fix
new Intl.DateTimeFormat(options.locale, { timeZone: 'America/New_York' });

@larsjkr larsjkr force-pushed the fix/time-zone-differs-on-client branch from 0d2bb72 to d9f6be8 Compare November 12, 2023 16:00
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da15ccd) 100.00% compared to head (d9f6be8) 99.10%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #197      +/-   ##
===========================================
- Coverage   100.00%   99.10%   -0.90%     
===========================================
  Files            3        3              
  Lines          105      112       +7     
  Branches         9       11       +2     
===========================================
+ Hits           105      111       +6     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe danielroe changed the title fix: timeZone differs on client fix: handle camel-case options correctly Feb 1, 2024
@danielroe
Copy link
Owner

My apologies for the long delay on reviewing this, and thank you for the fix ❤️

@danielroe danielroe merged commit 52a43cc into danielroe:main Feb 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date differs on server and browser with time-zone set.
3 participants