Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add oneof name and ignore options #32

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Conversation

danielvladco
Copy link
Owner

No description provided.

@westongcooper
Copy link

Thank you!

@danielvladco danielvladco merged commit 4bb632a into master Oct 20, 2021
@snikch
Copy link
Contributor

snikch commented Nov 10, 2021

Was it an active decision to require the oneof fields to have an uppercase first character? This is required to get oneofs working with the current implementation, as protoc-gen-gogql generates the type as MessageName_OneofFieldName but protoc-gen-gql generates the union type as MessageNameOneofFieldName. If the oneof field in the proto starts with a lower case name then the graphql generated type is MessageNameOneofFieldName, however if the first char is uppercase you get the correct MessageName_OneofFieldName - however you now have protobufs that no longer lint.

@danielvladco
Copy link
Owner Author

Hi @snikch,

I see your concern, it looks rather like a bug to me,
Can you please open an issue for this so it's easier to keep track?

And please provide expected and actual behaviour when creating the issue.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants