missing error messages from stderr

[wonderfulShrineMaidenOfParadise]

Reproduction steps

Ping something which returns errors.

Expected behavior

Messages from stderr are included in the responses.

{
  inputHost: 'p.p',
  host: 'unknown',
  alive: false,
  output: 'ping: permission denied (are you root?)\n',
  time: 'unknown',
  times: [],
  min: 'unknown',
  max: 'unknown',
  avg: 'unknown',
  stddev: 'unknown',
  packetLoss: 'unknown'
}
{
  inputHost: '1.1.1.1',
  host: '1.1.1.1',
  alive: false,
  output: 'PING 1.1.1.1 (1.1.1.1): 56 data bytes\nping: permission denied (are you root?)\n',
  time: 'unknown',
  times: [],
  min: 'unknown',
  max: 'unknown',
  avg: 'unknown',
  stddev: 'unknown',
  packetLoss: 'unknown',
  numeric_host: '1.1.1.1)'
}

Actual Behavior

The responses don't have messages from stderr included.

Relevant issue: louislam/uptime-kuma#2896

{
  inputHost: 'p.p',
  host: 'unknown',
  alive: false,
  output: '',
  time: 'unknown',
  times: [],
  min: 'unknown',
  max: 'unknown',
  avg: 'unknown',
  stddev: 'unknown',
  packetLoss: 'unknown'
}
{
  inputHost: '1.1.1.1',
  host: '1.1.1.1',
  alive: false,
  output: 'PING 1.1.1.1 (1.1.1.1): 56 data bytes\n',
  time: 'unknown',
  times: [],
  min: 'unknown',
  max: 'unknown',
  avg: 'unknown',
  stddev: 'unknown',
  packetLoss: 'unknown',
  numeric_host: '1.1.1.1)'
}

Operating System and Arch

Alpine 3.17 armv7

Ping

BusyBox v1.35.0

NodeJS Version

18.14.2

[mondwan]

Hello, errors reported here are too generic. Please include how you run the library, actual responses, and expected responses.

As mentioned in louislam/uptime-kuma/issues/2896, please also include how your system behaved while running the system ping if you believed the errors are coming from the system instead.

[wonderfulShrineMaidenOfParadise]

I updated the thread with outputs. We can know that output is empty if there is nothing in stdout. We should also include stderr for more info for debugging issues.

[mondwan]

Hopefully, #159 should resolve this bug

[mondwan]

Try release 0.4.4

[wonderfulShrineMaidenOfParadise]

{
  inputHost: 'p.p',
  host: 'bad',
  alive: false,
  output: "ping: bad address 'p.p'\n",
  time: 'unknown',
  times: [],
  min: 'unknown',
  max: 'unknown',
  avg: 'unknown',
  stddev: 'unknown',
  packetLoss: 'unknown',
  numeric_host: 'ddres'
}
{
  inputHost: '1.1.1.1',
  host: '1.1.1.1',
  alive: false,
  output: 'PING 1.1.1.1 (1.1.1.1): 56 data bytes\n' +
    'ping: permission denied (are you root?)\n',
  time: 'unknown',
  times: [],
  min: 'unknown',
  max: 'unknown',
  avg: 'unknown',
  stddev: 'unknown',
  packetLoss: 'unknown',
  numeric_host: '1.1.1.1)'
}

Thank you for fixing!

[mondwan]

That's great. Just wondering. Hopefully, you are using BusyBox or something like that. Can you also show me the value of "os.platform()"? The value in the numeric host field is bad. But, it is probably due to picking a wrong parser. The library should pick a Mac base parser for your case

…

On Sat, 11 Mar 2023, 22:13 Raymond Hackley, ***@***.***> wrote: { inputHost: 'p.p', host: 'bad', alive: false, output: "ping: bad address 'p.p'\n", time: 'unknown', times: [], min: 'unknown', max: 'unknown', avg: 'unknown', stddev: 'unknown', packetLoss: 'unknown', numeric_host: 'ddres' } { inputHost: '1.1.1.1', host: '1.1.1.1', alive: false, output: 'PING 1.1.1.1 (1.1.1.1): 56 data bytes\n' + 'ping: permission denied (are you root?)\n', time: 'unknown', times: [], min: 'unknown', max: 'unknown', avg: 'unknown', stddev: 'unknown', packetLoss: 'unknown', numeric_host: '1.1.1.1)' } Thank you for fixing! — Reply to this email directly, view it on GitHub <#158 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA5YBIZQBLZTHPVQO7YKMVDW3T2I7ANCNFSM6AAAAAAVTNQMSI> . You are receiving this because you commented.Message ID: ***@***.***>

[wonderfulShrineMaidenOfParadise]

Can you also show me the value of "os.platform()"?

linux. I don't really understand. Do you need to know something specific?

[mondwan]

I mean I would like to know the value from the module in node js os.platform().

In your captured sample, the value of the field numeric_host is 1.1.1.1), the ending bracket is something unexpected. Hopefully, we can fix this buggy value by picking a correct parser in the first place

Given that the format of ping's output depends on the underlying platform, there are 3 kinds of parsers in this library: MAC / LINUX / WINDOW. This library will pick the corresponding parser depends on the value from os.platform().

• FYI, https://github.com/danielzzz/node-ping/blob/v0.4.4/lib/ping-promise.js#L37

The problematic numeric_host value can be resolved as long as a MAC based parser being picked. That's why I would like to know the value of os.platform() for your underlying system. Then, I can fix the factory accordingly.

• FYI, https://github.com/danielzzz/node-ping/blob/v0.4.4/lib/builder/factory.js#L32

[mondwan]

Otherwise, I need to fix the linux parser accordingly. lol

[wonderfulShrineMaidenOfParadise]

Yes os.platform() returns linux and it seems to be correct.