Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py35 compat #3

Merged
merged 1 commit into from
Feb 9, 2019
Merged

Add py35 compat #3

merged 1 commit into from
Feb 9, 2019

Conversation

s-weigand
Copy link
Contributor

Adding compat for older python versions wasn't as simple as removing the f-strings, since os.PathLike and os.fspath (see) were added in python 3.6 .
So there are a lot of version checks to treat Path objects different in py35.
I'm not sure if that is what you want so I put it in a different PR than #1 .

For py34 there are even differences in how it gets compiled and since it won't be supported after March of 2019, I don't think it's worth having the code overhead.

@s-weigand s-weigand mentioned this pull request Feb 7, 2019
@danifus danifus merged commit b9fe131 into danifus:master Feb 9, 2019
@danifus
Copy link
Owner

danifus commented Feb 9, 2019

Thanks for your help. I didn't realise how broken the tox set up was before. I added support for 3.4 by throwing an exception if someone tries to use PyZipFile and skipping those tests. I don't think anyone will need that in 3.4

@s-weigand s-weigand deleted the py35-compat branch February 9, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants