Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding compat for older python versions wasn't as simple as removing the f-strings, since
os.PathLike
andos.fspath
(see) were added in python 3.6 .So there are a lot of version checks to treat Path objects different in py35.
I'm not sure if that is what you want so I put it in a different PR than #1 .
For py34 there are even differences in how it gets compiled and since it won't be supported after March of 2019, I don't think it's worth having the code overhead.