Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant files and codes from rnd folder #1

Closed
wants to merge 1 commit into from
Closed

Remove redundant files and codes from rnd folder #1

wants to merge 1 commit into from

Conversation

alirezakazemipour
Copy link

Summary of changes:

  • Change Common and Brain folders to python packages.
  • Remove play.py as that was not needed.
  • Remove Montezuma's Revenge environment wrappers as they were not needed.
  • Replace clip_grad_norm_ method with the official torch.clip_grad_norm_.

@danijar
Copy link
Owner

danijar commented Dec 14, 2021

Thanks for cleaning up! I'll keep the current version because reproduces the results in the paper and refactoring can sometimes introduce unexpected changes.

@danijar danijar closed this Dec 14, 2021
@alirezakazemipour
Copy link
Author

Definitely!
As what you consider to be appropriate.
It's been a pleasure anyway. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants