Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate to german and respect configured domain #9

Open
wants to merge 5 commits into
base: 3.x
Choose a base branch
from
Open

translate to german and respect configured domain #9

wants to merge 5 commits into from

Conversation

grafst
Copy link

@grafst grafst commented May 21, 2024

No description provided.

danilopolani
danilopolani requested changes Jun 13, 2024
View reviewed changes
Copy link
Owner

@danilopolani danilopolani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry for the delay, I was on holidays and then a lot of work :/
Thank you for the PR! I've just added a little comment and then we're ready :)

composer.json
@@ -1,5 +1,5 @@
{
"name": "danilopolani/filament-plausible-widget",
"name": "blemli/filament-plausible-widget",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should remain as-is 🙏

@grafst
Copy link
Author

grafst commented Sep 13, 2024

oh yes, very sorry you are right of course.
I hope a manage to amend this PR, have never done that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilopolani danilopolani danilopolani requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grafst @danilopolani