feat: add animation begin support on web #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasyan
commented
Feb 15, 2022
| @@ -126,6 +126,7 @@ const MyLoader = () => ( | |||
| | **`style?: React.CSSProperties`** <br /> Defaults to `{}` | React DOM only | | | |||
| | **`uniqueKey?: string`** <br /> Defaults to random unique id | React DOM only | Use the same value of prop key, <br/>that will solve inconsistency on the SSR, see more [here](https://github.com/danilowoz/react-content-loader/issues/78). | | |||
| | **`beforeMask?: JSX.Element`** <br /> Defaults to null | React DOM<br/>React Native | Define custom shapes before content, <br/>see more [here](https://github.com/danilowoz/react-content-loader/issues/266). | | |||
| | **`animateBegin?: string`** <br /> Defaults to `undefined` | React DOM only | Delay before the animation begins, identical to the [SVG animate element begin attribute](https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/begin) | |||
There was a problem hiding this comment.
Happy to co-locate this prop with the animate property above, but it looks like so far props in this list seem to have been added chronologically.
| parameters: { | ||
| notes: `##\`animateBegin?: string\` | ||
|
|
||
| Defaults to \`0s\`. This attribute accepts the same values as the SVG animate element's [\`begin\` attribute](https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/begin).`, |
There was a problem hiding this comment.
Note default to 0s is only implicit here; the actual default value lives with the begin attribute itself on the animation element.
|
@danilowoz would love to get feedback on this — let me know if there's anything I can do to help it get merged 😄 |
danilowoz
approved these changes
Feb 23, 2022
|
🎉 This PR is included in version 6.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a prop to expose the underlying web SVG
animationelement'sbeginattribute.(My specific motivation is to then be able to use this field to stagger a series of loading component animations, but I can imagine broader use-cases as well given the other possible values of the
beginattribute.)Related Issue #[issue number]
None
Any Breaking Changes
None
Checklist