return null for undefined relationships

closes #38
danivek · Dec 8, 2017 · 060fc40 · 060fc40
1 parent 0145b0e
commit 060fc40
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/JSONAPISerializer.js b/lib/JSONAPISerializer.js
@@ -606,7 +606,7 @@ module.exports = class JSONAPISerializer {
   serializeRelationship(rType, rData, rOptions, included, extraData) {
     // No relationship data
     if (rData === undefined) {
-      return undefined;
+      return null;
     }
 
     // Empty relationship data

diff --git a/test/unit/JSONAPISerializer.test.js b/test/unit/JSONAPISerializer.test.js
@@ -263,9 +263,9 @@ describe('JSONAPISerializer', function() {
       },
     });
 
-    it('should return undefined for an undefined relationship data', function(done) {
+    it('should return null for an undefined relationship data', function(done) {
       const serializedRelationshipData = Serializer.serializeRelationship('articles', undefined);
-      expect(serializedRelationshipData).to.eql(undefined);
+      expect(serializedRelationshipData).to.eql(null);
       done();
     });