forked from madler/zlib
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: mimic behavior of Makefile properly. Add test to be sure. #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dankegel
force-pushed
the
issue497-hobgoblin-of-small-minds-for-ci
branch
3 times, most recently
from
May 22, 2020 18:37
a287214
to
5e92a9a
Compare
Also add tooling/test-cmake.sh and tooling/test-make.sh, use at least the former in .cirrus-ci.yml.
dankegel
force-pushed
the
issue497-hobgoblin-of-small-minds-for-ci
branch
from
May 22, 2020 18:40
5e92a9a
to
3e356b7
Compare
dankegel
changed the title
cmake: mimic behavior of Makefile a bit better; mostly fixes issue #497?
cmake: mimic behavior of Makefile properly to fix issue #497
May 22, 2020
dankegel
changed the title
cmake: mimic behavior of Makefile properly to fix issue #497
cmake: mimic behavior of Makefile properly
May 22, 2020
dankegel
force-pushed
the
issue497-hobgoblin-of-small-minds-for-ci
branch
from
May 23, 2020 03:50
919bd21
to
c08b979
Compare
Probably want to be careful about using same compiler for both builds in general, but for now, hide it behind the FreeBSD conditional, since that's where I hit the problem.
dankegel
force-pushed
the
issue497-hobgoblin-of-small-minds-for-ci
branch
5 times, most recently
from
May 23, 2020 20:57
2d9f837
to
67c03b7
Compare
dankegel
force-pushed
the
issue497-hobgoblin-of-small-minds-for-ci
branch
from
May 23, 2020 21:19
67c03b7
to
9e26c19
Compare
dankegel
changed the title
cmake: mimic behavior of Makefile properly
cmake: mimic behavior of Makefile properly. ci: verify cmake and make produce same bits.
May 23, 2020
dankegel
changed the title
cmake: mimic behavior of Makefile properly. ci: verify cmake and make produce same bits.
cmake: mimic behavior of Makefile properly. ci: add test to verify.
May 23, 2020
dankegel
changed the title
cmake: mimic behavior of Makefile properly. ci: add test to verify.
cmake: mimic behavior of Makefile properly. Add test to be sure.
May 23, 2020
Closing in favor of the slightly improved and muchly squashed #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP to fix and verify issue madler#497