Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect result when rounding 1/3 with MidpointRounding.ToEven #39

Closed
lipchev opened this issue Apr 14, 2024 · 0 comments · Fixed by #40
Closed

Incorrect result when rounding 1/3 with MidpointRounding.ToEven #39

lipchev opened this issue Apr 14, 2024 · 0 comments · Fixed by #40

Comments

@lipchev
Copy link
Contributor

lipchev commented Apr 14, 2024

I've messed up one of the edge cases in the implementation of #23

  Name Value Type
▶ Fraction.Round(new Fraction(1,3), 2, MidpointRounding.ToEven) {17/50} Fractions.Fraction
  Fraction.Round(new Fraction(1,3), 2, MidpointRounding.ToEven).ToDecimal() 0.34 decimal
lipchev added a commit to lipchev/Fractions that referenced this issue Apr 14, 2024
@lipchev
- fixes danm-de#39 : Incorrect result when rounding 1/3 with Midpoint…
d3e29e8 
…Rounding.ToEven

- adds extra tests for the non-terminating fractions
@lipchev lipchev mentioned this issue Apr 14, 2024
Merged
danm-de added a commit that referenced this issue Apr 15, 2024
@danm-de
Merge pull request #40 from lipchev/master
5fa3fb8 
fixes #39 : Incorrect result when rounding 1/3 with MidpointRounding.ToEven
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #39 : Incorrect result when rounding 1/3 with MidpointRounding.ToEven lipchev/Fractions
1 participant
@lipchev