Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fractions.Tests: fix invalid characters in test names #25

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

lipchev
Copy link
Contributor

@lipchev lipchev commented Mar 30, 2024

  • all phrases translated into english (left comments in german)
  • english phrases modified (using "When" and "Should")
  • files re-formatted with file-scoped namespaces

- all phrases translated into english (left comments in german)
- english phrases modified (using "When" and "Should")
- files re-formatted with file-scoped namespaces
@lipchev
Copy link
Contributor Author

lipchev commented Mar 30, 2024

I hope you don't mind that I took some liberties with the names of the tests- I tried to make the AI follow the existing naming conventions, but if you'd like to change anything about the format, it wouldn't be any trouble.
Also, I doubt you needed the German translations but I figured- whatever it costs me nothing (I don't personally speak German..) - if you want, I'll remove them (make things a little less cluttered).

@danm-de
Copy link
Owner

danm-de commented Mar 31, 2024

Hi, thanks for your pull request. I'll take a look at it right away.

Copy link
Owner

@danm-de danm-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for translating the unit tests into English!

@danm-de danm-de merged commit 905694d into danm-de:master Mar 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants