Added extended xml comments to the FromDouble* methods (WIP) #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lipchev
commented
Apr 17, 2024
lipchev
commented
- Fraction.ConvertFrom split into Fraction.ConvertFromNumber and Fraction.ConvertFromString (no changes to the code)
- replaced the xml comments from the FromDouble* functions (providing details about the possible caveats with each one)
- replaced the Readme sections regarding the Creation from double with an extended version (including the new overload)
|
oh, did i miss some change in the ConvertFrom, why is this giving me a conflict.. 😕 |
lipchev
changed the title
|
Sorry, I do not want to split those files. |
|
Sure, no problem- I had messed up the branch anyway. I'll create a new one.. |
|
As a non-native English speaker, I think the documentation improvement is great. Unfortunately it's mixed up in this branch. |
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.