Integration: Lipchev support nan and infnity #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- NaN represented by {0/0}
- PositiveInfinity represented by {1/0}
- NegativeInfinity represented by {-1/0}
- Zero is now represented by {0/1}
updating the tests and the benchmark results
…(%) function - removed the GCD checking in the CompareTo (up to 2x peformaince gain) - refactored the Add/Multiply/Divide/Pow operations (another ~20% improvements on the BasicMathBenchmarks and up to 35% on the PowerMathBenchmarks) - adding more edge-case values to the benchmarks (this time actually using Pow(10, 37) instead of 10^37...)
… as solution items
…ction) is equal to Fraction.Zero` does not have to be checked everywhere. Replace backing fields with property (getter) - if possible (JIT will optimize this later).
BREAKING CHANGE: use current culture if no IFormatProvider is specified.
danm-de
changed the title
…ure if not provided.
danm-de
force-pushed
the
lipchev-support-nan-and-infnity
branch
from
1e1b827
to
ef4ab07
Compare
…torX” for better readability). Added some comments while reviewing the code changes.
Simplify IsZero property (remove duplicate condition)
|
I've just pushed a PR (#51) with some minor changes. (replaced one TODO with another 😄 ) |
lipchev
reviewed
Apr 29, 2024
Nullable denominator review
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to integrate pull request #48 with changes.