Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the comparisons with infinity #68

Conversation

lipchev
Copy link
Contributor

@lipchev lipchev commented May 26, 2024

  • added extra tests for the CompareTo and the Equals methods
  • updated the benchmark results (no difference w.r.t. ref readonly modifier)

@lipchev
Copy link
Contributor Author

lipchev commented May 26, 2024

@danm-de I cannot reopen the previous PR so here is another one. There are perhaps way too many tests but I've been using them to test every return statement on my optimized implementation. It's almost ready, and significantly faster- but I want to check a few more things before I publish it (probably tonight), so it would be easier if kept the extra tests for now..

@danm-de danm-de merged commit 70c2425 into danm-de:feature/default-to-value-equality May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants