Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You can play and win the game without resources #4

Closed
danmana opened this issue Oct 8, 2021 · 0 comments · Fixed by #9
Closed

You can play and win the game without resources #4

danmana opened this issue Oct 8, 2021 · 0 comments · Fixed by #9
Assignees
@dana-c0914

Comments

@danmana
Copy link
Owner

danmana commented Oct 8, 2021 •
edited
Loading

If you go directly to https://lost-in-space-danmana.vercel.app/execution you can play and win the game without any resources.
You can also reach this case if you refresh the page while playing.

The isDead test checks only the resources you add on the planning page.
We should always check food, water, oxygen, fuel, medicine (even if the user somehow gets to this page without them)

image
@dana-c0914 dana-c0914 self-assigned this Oct 24, 2021
@dana-c0914 dana-c0914 mentioned this issue Oct 24, 2021
Merged
danmana added a commit that referenced this issue Oct 25, 2021
@danmana
Merge pull request #9 from danmana/bug/4#redirectIfNoResources
53ac0dc 
fix #4 redirect to previous step if needed data is not available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dana-c0914 dana-c0914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #4 redirect to previous step if needed data is not available danmana/lost-in-space
2 participants
@danmana @dana-c0914