cmake/versions.cmake: version string must have 3 parts otherwise cmake might crash (#5204)

danmar · web-flow · commit 767c0fb3379d · 2023-06-28T16:25:11.000+02:00
diff --git a/cmake/versions.cmake b/cmake/versions.cmake
@@ -1,4 +1,5 @@
 # Version for libraries CPP
+# Version string must have 3 "parts". https://sourceforge.net/p/cppcheck/discussion/development/thread/e57efb2b62/
 SET(VERSION "2.11.99")
 STRING(REGEX MATCHALL "[0-9]+" VERSION_PARTS "${VERSION}")
 LIST(GET VERSION_PARTS 0 VERSION_MAJOR)
diff --git a/createrelease b/createrelease
@@ -31,7 +31,7 @@
 #
 # Update version numbers in:
 # sed -i -r "s/version 2[.][0-9]+([.]99)*/version 2.9/" cli/main.cpp
-# sed -i -r "s|2[.][0-9]+([.]99)*|2.9|" cmake/versions.cmake
+# sed -i -r "s|2[.][0-9]+([.]99)*|2.9.0|" cmake/versions.cmake # version must have 3 parts.
 # sed -i -r "s/MINOR [0-9]+/MINOR 9/" lib/version.h
 # sed -i -r "s/2[.][0-9]+([.]99)*/2.9/" win_installer/productInfo.wxi
 # sed -i -r "s/subtitle: Version 2\.[0-9]+/subtitle: Version 2.9/" man/*.md

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`# Version for libraries CPP`
	`2`	`+# Version string must have 3 "parts". https://sourceforge.net/p/cppcheck/discussion/development/thread/e57efb2b62/`
`2`	`3`	`SET(VERSION "2.11.99")`
`3`	`4`	`STRING(REGEX MATCHALL "[0-9]+" VERSION_PARTS "${VERSION}")`
`4`	`5`	`LIST(GET VERSION_PARTS 0 VERSION_MAJOR)`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@`
`31`	`31`	`#`
`32`	`32`	`# Update version numbers in:`
`33`	`33`	`# sed -i -r "s/version 2[.][0-9]+([.]99)*/version 2.9/" cli/main.cpp`
`34`		`-# sed -i -r "s\|2[.][0-9]+([.]99)*\|2.9\|" cmake/versions.cmake`
	`34`	`+# sed -i -r "s\|2[.][0-9]+([.]99)*\|2.9.0\|" cmake/versions.cmake # version must have 3 parts.`
`35`	`35`	`# sed -i -r "s/MINOR [0-9]+/MINOR 9/" lib/version.h`
`36`	`36`	`# sed -i -r "s/2[.][0-9]+([.]99)*/2.9/" win_installer/productInfo.wxi`
`37`	`37`	`# sed -i -r "s/subtitle: Version 2\.[0-9]+/subtitle: Version 2.9/" man/*.md`