Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabling views tracking #427

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Conversation

dostu
Copy link
Contributor

@dostu dostu commented Sep 9, 2021

If I set config.track_views = false in configuration, track_views method still returns true.

The issue was introduced with this commit: 0d82c5c

@danmayer danmayer self-requested a review September 10, 2021 22:44
@danmayer danmayer merged commit e2ed96e into danmayer:master Sep 10, 2021
@danmayer
Copy link
Owner

awesome thanks for the fix!

@dostu dostu deleted the disable-track-views branch September 11, 2021 19:35
@danmayer
Copy link
Owner

danmayer commented Jan 2, 2022

@dostu this is in gem 'coverband', '= 5.2.0.rc.1' if you want to help test the RC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants