Migrate Croptool tool to the Kubernetes buildservice architecture #192
Conversation
|
A live version of this deployment can be found at https://soda-test.toolforge.org |
|
This is awesome! \o/ thanks a lot for working on this. |
|
Ack, I'll see if I'm able to make some of the changes (particularly shifting to apache2) :) |
|
Apache2 migration worked and fixed a bunch of the other issues as well :) |
| $app->get('/api/server-cleanup', function ($request, $response) { | ||
| exec( ROOT_PATH . '/scripts/cleanup.sh &'); | ||
| $response->getBody()->write('STARTED'); | ||
| return $response->withStatus(200); |
There was a problem hiding this comment.
Clever way to migrate the cleanup part 👍
|
Unfortunately the magic border detection is still broken after this update. We believe the fix is surprisingly trivial, see danmichaelo/php-coma#3 or alternatively danmichaelo/php-coma#2. Please let us know how else we can help. Many in the Wikimedia Commons community rely quite heavily on the CropTool. |
Notable changes
php8.2(which entailed migration from Slim 3 to Slim 4 !)config.dev.iniandconfig.prod.iniare two different files now,config.dev.inishould be used for development,config.prod.inifor Toolforge(etc)
Issues
(Please squash and merge this pull request)