[BUG] [regression] Broken status report for early failed requests after e121f683c28f99a7d071121852e8dcd4e08eed66 merge

[fernflower]

tesar report -c UUID doesn't work as expected

(.venv) [ivasilev@ivasilev-thinkpadp1gen4i tesar]$ tesar report -c 6b4ea828-52b9-4575-b4be-382b2b510b0a
Reporting for the requested tasks:
RHEL-8.8.0-Nightly None https://api.dev.testing-farm.io/v0.1/requests/6b4ea828-52b9-4575-b4be-382b2b510b0a COMPLETE
Traceback (most recent call last):
  File "/home/ivasilev/projects/tesar/.venv/lib/python3.11/site-packages/report/__main__.py", line 234, in parse_request_xunit
    testsuite_arch = elem.xpath("./testing-environment/property[@name='arch']/@value")[0]
                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
IndexError: list index out of range

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ivasilev/projects/tesar/.venv/bin/tesar", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/ivasilev/projects/tesar/.venv/lib/python3.11/site-packages/tesar/__init__.py", line 23, in main
    sys.exit(report())
             ^^^^^^^^
  File "/home/ivasilev/projects/tesar/.venv/lib/python3.11/site-packages/report/__main__.py", line 511, in main
    result_table = build_table_comparison() if ARGS.compare else build_table()
                                                                 ^^^^^^^^^^^^^
  File "/home/ivasilev/projects/tesar/.venv/lib/python3.11/site-packages/report/__main__.py", line 407, in build_table
    parsed_dict = parse_request_xunit(skip_pass=ARGS.skip_pass)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ivasilev/projects/tesar/.venv/lib/python3.11/site-packages/report/__main__.py", line 236, in parse_request_xunit
    testsuite_arch = elem.xpath("./@name")[0].split(":")[1]
                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
IndexError: list index out of range

Git blame points to

commit e121f683c28f99a7d071121852e8dcd4e08eed66
Author: Pavel Holica <pholica@redhat.com>
Date:   Tue Aug 29 09:37:06 2023 +0200

    Add --showarch option to report command
    
    This option adds new Arch column to the report table.

I believe it's time we introduced mandatory unit tests for basic apis and any new features.

[github-actions]

Hi, there.

Thank you @fernflower for submitting the bug report. Someone will take a look at this shortly.

---

This is an automated comment created by the peaceiris/actions-label-commenter. Responding to the bot or mentioning it won't have any effect.

[danmyway]

Hi! After an initial investigation, this does not look like a regression.
What happens is that the request ended with complete state, but the overall "testsuite" result was an error.
We correctly fall back to the results.xml file, we just need to bail out, when the only result available are testsuite name - pipeline and testsuite overall_result is an error.
I have already drafted a fix for this, will provide in a PR soon.

[pholica]

Yeah, I've just tried it before the commit and it also crashed before:

$ git checkout e121f683c28f99a7d071121852e8dcd4e08eed66^
...
$ PYTHONPATH=$(pwd)/src python3 -m tesar report -c 6b4ea828-52b9-4575-b4be-382b2b510b0a
Reporting for the requested tasks:
RHEL-8.8.0-Nightly None https://api.dev.testing-farm.io/v0.1/requests/6b4ea828-52b9-4575-b4be-382b2b510b0a COMPLETE
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/home/pholica/git/ddiblik/tesar/src/tesar/__main__.py", line 6, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/pholica/git/ddiblik/tesar/src/tesar/__init__.py", line 23, in main
    sys.exit(report())
             ^^^^^^^^
  File "/home/pholica/git/ddiblik/tesar/src/report/__main__.py", line 495, in main
    result_table = build_table_comparison() if ARGS.compare else build_table()
                                                                 ^^^^^^^^^^^^^
  File "/home/pholica/git/ddiblik/tesar/src/report/__main__.py", line 401, in build_table
    parsed_dict = parse_request_xunit(skip_pass=ARGS.skip_pass)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pholica/git/ddiblik/tesar/src/report/__main__.py", line 232, in parse_request_xunit
    testsuite_result = elem.xpath("./@result")[0].upper()
                       ~~~~~~~~~~~~~~~~~~~~~~~^^^
IndexError: list index out of range

[danmyway]

fix available in #71 @fernflower