feat: Exporting all conversations in one go #2701
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubmieszczak
changed the title
jakubmieszczak
force-pushed
the
jakub.export-all-convos
branch
3 times, most recently
from
c3cf09b
to
2b36d78
Compare
jakubmieszczak
changed the title
| logger.info('Downloading JSON file'); | ||
| try { | ||
| //put this in a function | ||
| const { jobId } = req.params; |
There was a problem hiding this comment.
Should we put that in a function?
There was a problem hiding this comment.
I remember that we wanted to handle user id and job id to make sure we return the appropriate http code
| }; | ||
|
|
||
| const downloadConversationsJsonFile = (data) => { | ||
| // Assuming `data` is the downloadable content; adjust as necessary for your use case |
|
|
||
| const downloadConversationsJsonFile = (data) => { | ||
| // Assuming `data` is the downloadable content; adjust as necessary for your use case | ||
| const blob = new Blob([JSON.stringify(data, null, 2)], { type: 'application/json' }); |
There was a problem hiding this comment.
Hm, this seems not optimal. We kind of downloading potentially big file then storing it in memory. Can't we download it directly?
| }; | ||
|
|
||
| const pollJobStatus = (jobId, onSuccess, onError) => { | ||
| const intervalId = setInterval(async () => { |
There was a problem hiding this comment.
Wouldn't it be the same as pollJobStatus?
|
It would be nice to add a unit tests for this functionality. |
|
Great comments @DenisPalnitsky Also thank you @jakubmieszczak for tackling this! 🙏 |
jakubmieszczak
force-pushed
the
jakub.export-all-convos
branch
3 times, most recently
from
891bbc6
to
10b58d1
Compare
jakubmieszczak
force-pushed
the
jakub.export-all-convos
branch
from
09c163c
to
3ed5f81
Compare
jakubmieszczak
force-pushed
the
jakub.export-all-convos
branch
from
3ed5f81
to
be6ce47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
--- WIP ---
Summary
--- WIP ---
Change Type
Please delete any irrelevant options.
Testing
--- WIP ---
Test Configuration:
Checklist
Please delete any irrelevant options.