Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 feat: Add titling to Google client #2983

Merged
merged 4 commits into from
Jun 22, 2024

Conversation

mungewrath
Copy link
Contributor

Summary

Enables auto-generated titles when using Google models, as described in Issue 1422

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update - see feat: Add titling to Google client LibreChat-AI/librechat.ai#45
  • Translation update

Testing

  • Tested with gemini-1.5-pro-latest
  • Tested with gemini-pro
  • Tested with invalid model name, and confirmed backend fails gracefully

Test Configuration:

Use GOOGLE_TITLE_MODEL environment variable in .env if desired to test specific model

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes
  • A pull request for updating the documentation has been submitted.

@danny-avila
Copy link
Owner

Thanks for this. Will review and slate for v0.7.4. I was hoping to make use of Google's tool/functions for this, but I will see how well this works with vertex/gemini api

api/app/clients/GoogleClient.js Outdated Show resolved Hide resolved
api/app/clients/GoogleClient.js Show resolved Hide resolved
@danny-avila danny-avila changed the title feat: Add titling to Google client 🤖 feat: Add titling to Google client Jun 22, 2024
@danny-avila danny-avila merged commit b5081bf into danny-avila:main Jun 22, 2024
danny-avila pushed a commit that referenced this pull request Aug 5, 2024
* feat: Add titling to Google client

* feat: Add titling to Google client

* PR feedback changes
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
* feat: Add titling to Google client

* feat: Add titling to Google client

* PR feedback changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants