Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unbreak m18_pure #32

Closed
wants to merge 1 commit into from
Closed

unbreak m18_pure #32

wants to merge 1 commit into from

Conversation

npfoss
Copy link
Collaborator

@npfoss npfoss commented Sep 14, 2018

No description provided.

@dannybd
Copy link
Owner

dannybd commented Sep 14, 2018

Can you explain? Pushing this will immediately break everyone who has m18_theoretical in a saved road.

If you really need it, maybe define something like majors.m18_pure = majors.’18_theoretical?

@npfoss
Copy link
Collaborator Author

npfoss commented Sep 14, 2018

ohhh sorry sorry. I thought the breaking change went through in the other PR and needed to be undone! never mind

@npfoss npfoss closed this Sep 14, 2018
@dannybd
Copy link
Owner

dannybd commented Sep 14, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npfoss @dannybd