Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of NSE & NEET Updates #35

Merged
merged 6 commits into from
Apr 9, 2019
Merged

Conversation

hereiam-at-mit-dot-edu
Copy link
Contributor

Just changes to the majors.js file, comprising updates to NEET and Course 22. If you can merge this one soon, the NEET folks would like to launch everything today, simultaneously, so the sooner this goes up the better for them.

@npfoss
Copy link
Collaborator

npfoss commented Apr 9, 2019

Hey Michael, thanks for the diligence with requirements and stuff! We're actually about to launch the completely new courseroad in a week (secretly public here), so I'll still merge this in for you but you may want to check that out because it depends on a different and better-organized requirement structure and that's what people will be using after next Wednesday. I'm sorry you went through all this trouble not knowing about the new version's timeline...

@npfoss
Copy link
Collaborator

npfoss commented Apr 9, 2019

Before pushing to the main site, could you please go to my clone (for testing) and just confirm that the changes are what you expect?

@hereiam-at-mit-dot-edu
Copy link
Contributor Author

hereiam-at-mit-dot-edu commented Apr 9, 2019 via email

@npfoss npfoss merged commit 884ffdc into dannybd:master Apr 9, 2019
@npfoss
Copy link
Collaborator

npfoss commented Apr 9, 2019

Should be live now!

Unfortunately there isn't a way to automatically convert from one format to the other. The new format is nice in that it lets you add more user-facing descriptions and have some more control over stuff like that, but even if you don't feel like going through all that work again I'd still send feedback through that link letting the FireRoad team (and @venkatesh-sivaraman in particular) know that NEET needs updating, and someone will get to it eventually.

@hereiam-at-mit-dot-edu
Copy link
Contributor Author

hereiam-at-mit-dot-edu commented Apr 9, 2019 via email

@npfoss
Copy link
Collaborator

npfoss commented Apr 9, 2019

We'll keep the old courseroad up indefinitely so people can export their roads to the new version, but it will become permanently un-maintained next Wednesday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants