Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final Review #1 #52

Merged
merged 6 commits into from
Apr 19, 2019
Merged

Final Review #1 #52

merged 6 commits into from
Apr 19, 2019

Conversation

dannyi96
Copy link
Owner

No description provided.

@dannyi96 dannyi96 changed the title test changes Final Review #1 Apr 18, 2019
@pshreyasv100
Copy link
Collaborator

Is the statistics plotting with labels working properly , i had commented the labels part ?

pshreyasv100
pshreyasv100 approved these changes Apr 19, 2019
View reviewed changes
Copy link
Collaborator

@pshreyasv100 pshreyasv100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good merge it

@dannyi96
Copy link
Owner Author

Made some changes:

  1. Made mut_prob store both possible mutation rate values- static as well as dynamic mutation depending on scenario so that the Evolution need not be concerned whether adaptive mutation is used or not
  2. Allowed all other statistics to be stored even when adaptive mutation is false
  3. Added repeat_chromosome_sorting(default False) parameter to handle_selection so user can explicitly make chromosomes to be ordered by fitness in case he adds some chromosomes etc in Evolution before calling handle_selection

@dannyi96 dannyi96 merged commit 70d65d9 into phase1 Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshreyasv100 pshreyasv100 pshreyasv100 approved these changes

@BharatRajT BharatRajT Awaiting requested review from BharatRajT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannyi96 @pshreyasv100 @BharatRajT