Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import statements in test and add ignore comment for pyxel #7

Merged
merged 1 commit into from
Oct 10, 2021
Merged

fix: import statements in test and add ignore comment for pyxel #7

merged 1 commit into from
Oct 10, 2021

Conversation

eggplants
Copy link
Contributor

@eggplants eggplants commented Oct 10, 2021

pyxelのpyrightでのImport 'pyxel' could not be resolved Pyright (reportMissingImports)エラーの抑制とtestの修正をしました。(パッケージ関係には影響ありません。)

@dannyso16
Copy link
Owner

@eggplants pyrightなどで静的型チェックやフォーマット修正をしていなかったので助かります。
このプルリクエストは、#8 の解決まではしていないとの認識で大丈夫ですか?

@eggplants
Copy link
Contributor Author

そうです。

@dannyso16 dannyso16 merged commit c10a77d into dannyso16:master Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants